Use `@handlebars/parser` v2 #1866

jaylinski · 2022-05-20T20:40:53Z

See https://github.com/handlebars-lang/handlebars-parser/releases/tag/v2.0.0

jaylinski · 2022-05-20T21:13:35Z

It seems the ts compilation (https://github.com/handlebars-lang/handlebars-parser/blob/v2.1.0/package.json#L23) does something that rollup.js doesn't like.

Note: typescript, when targeting es5, will use global this for transpilation. Rollup warns about this, since it replaces this with undefined:

> rollup-test@1.0.0 build
> rollup --config rollup.config.js --failAfterWarnings


src/index.js → dist/bundle.js...
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
../../../node_modules/@handlebars/parser/dist/esm/printer.js
1: var __spreadArrays = (this && this.__spreadArrays) || function () {
                         ^
2:     for (var s = 0, i = 0, il = arguments.length; i < il; i++) s += arguments[i].length;
3:     for (var r = Array(s), k = 0, i = 0; i < il; i++)
...and 1 other occurrence
../../../node_modules/@handlebars/parser/dist/esm/helpers.js
1: var __spreadArrays = (this && this.__spreadArrays) || function () {
                         ^
2:     for (var s = 0, i = 0, il = arguments.length; i < il; i++) s += arguments[i].length;
3:     for (var r = Array(s), k = 0, i = 0; i < il; i++)
...and 1 other occurrence
created dist/bundle.js in 265ms
[!] Warnings occurred and --failAfterWarnings flag present

Fix would be to target es6 or run rollup and ignore the warning.

We have to remove `--failAfterWarnings` from our Rollup integration-test, because Typescript, when targeting es5, will use global `this` for transpilation. Rollup warns about this, since it replaces `this` with `undefined`: ``` src/index.js → dist/bundle.js... (!) `this` has been rewritten to `undefined` https://rollupjs.org/guide/en/#error-this-is-undefined ../../../node_modules/@handlebars/parser/dist/esm/printer.js 1: var __spreadArrays = (this && this.__spreadArrays) || function () {} ``` See https://github.com/handlebars-lang/handlebars-parser/releases/tag/v2.0.0

jaylinski self-assigned this May 20, 2022

jaylinski force-pushed the parser-v2 branch from 40b9609 to b294b55 Compare October 29, 2022 19:57

jaylinski merged commit e668696 into master Oct 29, 2022
12 checks passed

jaylinski deleted the parser-v2 branch October 29, 2022 20:09

Use `@handlebars/parser` v2 #1866

Use `@handlebars/parser` v2 #1866

jaylinski commented May 20, 2022

jaylinski commented May 20, 2022 •

edited

Use @handlebars/parser v2 #1866

Use @handlebars/parser v2 #1866

Conversation

jaylinski commented May 20, 2022

jaylinski commented May 20, 2022 • edited

Use `@handlebars/parser` v2 #1866

Use `@handlebars/parser` v2 #1866

jaylinski commented May 20, 2022 •

edited