New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge branch 4.x into master #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jaylinski
commented
Dec 3, 2021
403157e
to
be905dc
Compare
If `global` is used and handlebars is compiled for browser usage without a Node.js `global` polyfill, handlebars fails with a `global is undefined` error. Fixes #1593
First part of reorganizing and cleaning up test-folders.
Second part of reorganizing and cleaning up test-folders.
Third part of reorganizing and cleaning up test-folders.
Also removed it from published files, since the script doesn't seem to be used. Fourth part of reorganizing and cleaning up test-folders.
Also reorganized npm scripts.
AMD modules were removed in v5.
Fixes the following error when running integration-tests: ``` npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: webpack-test@1.0.0 npm ERR! Found: handlebars@5.0.0-alpha.1 npm ERR! node_modules/handlebars npm ERR! dev handlebars@"file:../../.." from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer handlebars@">= 1.3.0 < 5" from handlebars-loader@1.7.1 npm ERR! node_modules/handlebars-loader npm ERR! dev handlebars-loader@"^1.7.1" from the root project npm ERR! ```
Also upgraded to `@definitelytyped/dtslint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.