Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
base repository: handlebars-lang/handlebars.js
base: v4.5.2
Choose a base ref
...
head repository: handlebars-lang/handlebars.js
compare: v4.5.3
Choose a head ref
  • 9 commits
  • 28 files changed
  • 1 contributor

Commits on Nov 15, 2019

  1. fix: use !== 0 instead of != 0

    @nknapp
    nknapp committed Nov 15, 2019
    Copy the full SHA
    c02b05f View commit details
    Browse the repository at this point in the history

  2. chore: add chai and dirty-chai for better test assertions

    @nknapp
    nknapp committed Nov 15, 2019
    Copy the full SHA
    93e284e View commit details
    Browse the repository at this point in the history

  3. test: add sinon.js for spies, deprecate current assertions 

    - the goal is to get overall cleaner test.
- chai and sinon are standard libraries for testing
  assertions and spies. We should not use custom ones.
    @nknapp
    nknapp committed Nov 15, 2019
    Copy the full SHA
    93516a0 View commit details
    Browse the repository at this point in the history

  4. test: add sinon as global variable to eslint in the specs

    @nknapp
    nknapp committed Nov 15, 2019
    Copy the full SHA
    0817dad View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. test/chore: add chai/expect and sinon to "runtime"-environment

    @nknapp
    nknapp committed Nov 17, 2019
    1
    Copy the full SHA
    886ba86 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2019

  1. fix: add more properties required to be enumerable 

    - __defineGetter__, __defineSetter__, __lookupGetter__, __proto__
    @nknapp
    nknapp committed Nov 18, 2019
    Copy the full SHA
    1988878 View commit details
    Browse the repository at this point in the history

  2. fix: add "no-prototype-builtins" eslint-rule and fix all occurences

    @nknapp
    nknapp committed Nov 18, 2019
    1
    Copy the full SHA
    f7f05d7 View commit details
    Browse the repository at this point in the history

  3. Update release notes

    @nknapp
    nknapp committed Nov 18, 2019
    Copy the full SHA
    827c9d0 View commit details
    Browse the repository at this point in the history

  4. v4.5.3

    @nknapp
    nknapp committed Nov 18, 2019
    Copy the full SHA
    c819c8b View commit details
    Browse the repository at this point in the history